You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change uses the message pack formatters to serialize and deserialize the project configuration file. Of particular note, I added support to the message pack formatters for "skimming". The idea is that, when deserializing tag helpers, we look at the checksum first and determine whether that tag helper is in our cache. If it is, partially deserialize the tag helper by skimming through the byte stream. While skipping, we ensure that the SerializerCachingOptions are populated correctly with cached streams and MetadataCollections. In addition, because we're no longer serializing the file as "json", I've changed the file extension to ".bin".
This change allows message pack formatters to support "skimming" or
partially deserializing objects. This is needed to allow quickly
skipping through tag helpers that are already cached by checksum
without deserializing them. Skimming ensures that the
`SerializerCachingOptions` are correctly populated.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and exciting results.
My only question is why Skim uses ReadArrayHeader and not ReadArrayHeaderAndVerify (and whether "Skim" is the right name, and whether ".bin" is the right file extension 😛)
My only question is why Skim uses ReadArrayHeader and not ReadArrayHeaderAndVerify
I looked through and didn't spot anyplace where Skim(...) didn't use ReadArrayHeaderAndVerify where the number of elements is know. Do you have a pointer to the code where you noticed this?
I looked through and didn't spot anyplace where Skim(...) didn't use ReadArrayHeaderAndVerify where the number of elements is know. Do you have a pointer to the code where you noticed this?
I saw this and figured it could be ReadArrayHeaderAndVerify(checksums.Length), then saw the others and thought it must be deliberate. Now that I've had a better look, I think that might be the only place it could apply.
I saw this and figured it could be ReadArrayHeaderAndVerify(checksums.Length), then saw the others and thought it must be deliberate. Now that I've had a better look, I think that might be the only place it could apply.
Good catch! Very good idea to use ReadArrayHeaderAndVerify(...) and avoid a Debug.Assert.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added this to the 
This change uses the message pack formatters to serialize and deserialize the project configuration file. Of particular note, I added support to the message pack formatters for "skimming". The idea is that, when deserializing tag helpers, we look at the checksum first and determine whether that tag helper is in our cache. If it is, partially deserialize the tag helper by skimming through the byte stream. While skipping, we ensure that the
SerializerCachingOptionsare populated correctly with cached streams andMetadataCollections. In addition, because we're no longer serializing the file as "json", I've changed the file extension to ".bin".